Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for {@const} inside snippet block #9904

Merged
merged 5 commits into from Dec 13, 2023

Conversation

navorite
Copy link
Contributor

@navorite navorite commented Dec 13, 2023

Svelte 5 rewrite

Fixes #9897

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 13, 2023

🦋 Changeset detected

Latest commit: ed7d5e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 13, 2023

@navorite is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@trueadm
Copy link
Contributor

trueadm commented Dec 13, 2023

Please can you add a test showing that it works?

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 2:17pm

@navorite
Copy link
Contributor Author

navorite commented Dec 13, 2023

Please can you add a test showing that it works?

Done — sorry for not adding one.

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@trueadm trueadm merged commit 55656f5 into sveltejs:main Dec 13, 2023
7 of 8 checks passed
@vercel vercel bot temporarily deployed to Preview – svelte-dev December 13, 2023 14:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Allow @const inside an snippet block
2 participants