Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support hydrating around <noscript> #9953

Merged
merged 3 commits into from
Dec 27, 2023
Merged

fix: support hydrating around <noscript> #9953

merged 3 commits into from
Dec 27, 2023

Conversation

tombl
Copy link
Contributor

@tombl tombl commented Dec 18, 2023

Instead of deleting <noscript> elements in client templates, replace them with <!>. Solves #9952.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: c5e9373

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 18, 2023

@tombl is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@trueadm
Copy link
Contributor

trueadm commented Dec 27, 2023

This needs a changeset please.

@trueadm trueadm merged commit c0a357c into sveltejs:main Dec 27, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants