chore: skip generating $.proxy() calls for more expressions #9979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b871f95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@jeremy-deutsch is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
trueadm
approved these changes
Dec 27, 2023
|
@jeremy-deutsch Please could you add a changeset for this PR? Thanks :) |
jeremy-deutsch
force-pushed
the
fewer-proxy-calls
branch
from
f877a78
to
2f2af3e
Compare
Sure thing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9966.
This PR adds unary and binary expressions to the list of cases where expressions being assigned to state don't get wrapped in
$.proxy()in the generated output.Unary and binary expressions (e.g.
+x,!x,x + y,x in y) can never produce object values, so it doesn't make sense to wrap them in$.proxy().