-
-
Notifications
You must be signed in to change notification settings - Fork 99
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(test): improve stability by removing a log and vite cache (#894)
* fix(test): improve stability by removing an unexpected log and ensuring that vite cache isn't persisted * fix: remove log use * fix: wait 500ms after vite connected * increase timeout in ci * fix: remove workaround to mount test apps with svelte 4 or 5 * chore(docs): improve changelog about removal of svelte5 warning
- Loading branch information
Showing
20 changed files
with
127 additions
and
188 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@sveltejs/vite-plugin-svelte': patch | ||
--- | ||
|
||
Remove log about experimental status of Svelte 5. Note that breaking changes can still occur while vite-plugin-svelte 4 is in prerelease mode |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.body }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.body })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.body }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.body })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.body }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.body })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.body }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.body })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.body }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.body })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.body }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.body })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.body }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.body })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.body }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.body })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.getElementById('app') }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.getElementById('app') })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.body }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.body })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.body }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.body })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.body }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.body })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,3 @@ | ||
import App from './App.svelte'; | ||
|
||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.getElementById('app') }); | ||
} else { | ||
import('svelte').then(({ mount }) => mount(App, { target: document.getElementById('app') })); | ||
} | ||
import { mount } from 'svelte'; | ||
mount(App, { target: document.body }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,12 @@ | ||
import type { Test } from './lib.js'; | ||
import { test } from './lib.js'; | ||
import App from './App.svelte'; | ||
import { mount } from 'svelte'; | ||
|
||
main(); | ||
|
||
export function main({ arg = true }: Test = {}): void { | ||
if (arg && test()) { | ||
if (App.toString().startsWith('class ')) { | ||
new App({ target: document.body }); | ||
} else { | ||
import('svelte').then(({ mount }) => { | ||
mount(App, { target: document.body }); | ||
}); | ||
} | ||
mount(App, { target: document.body }); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.