fix: don't try to resolve internal node modules via package.json svel…

…te field (#266) * fix: don't try to resolve internal node modules via package.json svelte field * chore: merge imports
sveltejs · Feb 4, 2022 · ed8a19c · ed8a19c
1 parent 5786dab
commit ed8a19c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/.changeset/chatty-trees-sell.md b/.changeset/chatty-trees-sell.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/vite-plugin-svelte': patch
+---
+
+don't try to resolve node internal modules via package.json svelte field
diff --git a/packages/vite-plugin-svelte/src/utils/resolve.ts b/packages/vite-plugin-svelte/src/utils/resolve.ts
@@ -1,5 +1,5 @@
 import path from 'path';
-import { createRequire } from 'module';
+import { builtinModules, createRequire } from 'module';
 import { is_common_without_svelte_field, resolveDependencyData } from './dependencies';
 import { VitePluginSvelteCache } from './vite-plugin-svelte-cache';
 
@@ -8,7 +8,12 @@ export function resolveViaPackageJsonSvelte(
 	importer: string | undefined,
 	cache: VitePluginSvelteCache
 ): string | void {
-	if (importer && isBareImport(importee) && !is_common_without_svelte_field(importee)) {
+	if (
+		importer &&
+		isBareImport(importee) &&
+		!isNodeInternal(importee) &&
+		!is_common_without_svelte_field(importee)
+	) {
 		const cached = cache.getResolvedSvelteField(importee, importer);
 		if (cached) {
 			return cached;
@@ -28,6 +33,10 @@ export function resolveViaPackageJsonSvelte(
 	}
 }
 
+function isNodeInternal(importee: string) {
+	return importee.startsWith('node:') || builtinModules.includes(importee);
+}
+
 function isBareImport(importee: string): boolean {
 	if (
 		!importee ||