Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't reinclude excluded dependencies in automatic handling #159

Merged
merged 2 commits into from
Sep 1, 2021
Merged

fix: don't reinclude excluded dependencies in automatic handling #159

merged 2 commits into from
Sep 1, 2021

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Sep 1, 2021

This allows users to prevent certain reincludes that could break vite's optimizer, eg @types/node

@dominikg dominikg requested a review from bluwy September 1, 2021 17:19
bluwy
bluwy approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if we go down this path

@dominikg dominikg merged commit 0141699 into main Sep 1, 2021
@dominikg dominikg deleted the fix/never-include-excluded branch September 1, 2021 18:43
@github-actions github-actions bot mentioned this pull request Sep 1, 2021
Merged
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dominikg @bluwy