fix: add svelte lib without components to noExternal #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sveltejs/kit#2397
Note: I can't really add a failing test since the linked
e2e-test-dep-svelte-api-only
package is automaticallynoExternal
by default. I can't force it to external viaconfig.kit.vite.ssr.external
either since our code respects that (not actually testing the bug). For now, I've tested with the issue's repro https://github.com/Nickersoft/urql-repro and it works.