Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the resolved vite root #247

Merged
merged 2 commits into from
Jan 6, 2022
Merged

fix: use the resolved vite root #247

merged 2 commits into from
Jan 6, 2022

Commits on Jan 6, 2022

  1. fix: use the resolved vite root 

    Although vite-plugin-svelte needs to infer a root in order to pre-scan
svelte dependencies, it should use the root returned in configResolved
to ensure compatibility with backend integrations and other plugins that
might modify the root.

Since vite-plugin-svelte uses `enforce: 'pre'`, it's not viable for
other plugins to workaround this by using `enforce: 'pre'`, since the
behavior would become order-dependent on how the user applies the
plugins, which is error-prone and would result in a bad user experience.
    @ElMassimo
    ElMassimo committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    f750a57 View commit details
    Browse the repository at this point in the history

  2. chore: add changeset

    @ElMassimo
    ElMassimo committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    c678648 View commit details
    Browse the repository at this point in the history