-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export vitePreprocess
API
#509
Conversation
yes to deprecate, the improvement in DX makes using the plugin option inferior. we can add docs how to migrate. it's experimental still so no semver constraints |
I'd be curious if there's been any rough benchmarking to see if this is faster. esbuild is obviously faster, but you'd also have to call out to another process which is slower (I think once per file), so I wonder if it's overall faster. If we can confirm it's faster, I wonder if this should be made the default in |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Export
vitePreprocess()
Svelte preprocessor from@sveltejs/vite-plugin-svelte
. (Previously exported from/preprocess
subpath but now root)experimental.useVitePreprocess
is deprecated.Things I'm still thinking of, but could be a future problem:
useVitePreprocess
?vitePreprocess
tosvelte.config.js
but that results in two same preprocessors running at the same time. Should we deduplicate them internally?ResolvedConfig
, do we want to share it to the style preprocessor? If the user passes anInlineConfig
to the style preprocessor, it makes config merging not possible. Also it feels a bit magical 馃EDIT: Answered: