Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert compile error on hmr #592

Merged
merged 2 commits into from
Feb 22, 2023
Merged

fix: convert compile error on hmr #592

merged 2 commits into from
Feb 22, 2023

Conversation

dominikg
Copy link
Member

fixes #588

bluwy
bluwy approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. May want to edit the PR title before merging too so it matches semantic style

@dominikg dominikg changed the title Fix/convert compile error on hmr fix: convert compile error on hmr Feb 22, 2023
@dominikg dominikg merged commit 6c8206a into main Feb 22, 2023
@dominikg dominikg deleted the fix/convert-compile-error-on-hmr branch February 22, 2023 12:23
@github-actions github-actions bot mentioned this pull request Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parse error is swallowed when bad edit occurs via HMR
2 participants
@dominikg @bluwy