Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move inspector to separate package #646

Merged
merged 6 commits into from
May 17, 2023
Merged

refactor: move inspector to separate package #646

merged 6 commits into from
May 17, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented May 12, 2023

Closes #558

  • Created packages/vite-plugin-svelte-inspector with JSDoc
  • Named it @sveltejs/vite-plugin-svelte-inspector (quite a long name)
  • Copied most of the code, except some small refactors including:
    • Debug logs are done directly with the debug package
    • Warning and error logs uses Vite's config.logger API
    • Removed some logs which I'm not sure was helpful (happy to walk back if needed)
    • Refactor idToFile to not handle /@fs/, since that should never happen

@bluwy bluwy changed the title Refactor inspector as separate package refactor: move inspector to separate package May 12, 2023
@bluwy bluwy merged commit 1dd6933 into main May 17, 2023
7 checks passed
@bluwy bluwy deleted the refactor-inspector-package branch May 17, 2023 06:21
@github-actions github-actions bot mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikg dominikg dominikg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move svelte-inspector into it's own separate package
2 participants
@bluwy @dominikg