Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape keys #880

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Escape keys #880

merged 4 commits into from
Apr 8, 2024

Conversation

ryangclark
Copy link
Contributor

Implements escapeKeys as an enhancement to allow closing the inspector via a hotkey, as requested by #858.

By default, the escapeKeys are Backspace and Escape, though they can be configured via SVELTE_INSPECTOR_OPTIONS like the inspector's other hotkeys.

@dominikg
Copy link
Member

dominikg commented Apr 7, 2024

thank you for working on this. Please run pnpm generate:types in the inspector directory and commit/push the changes. This is needed because we ship the source to npm directly without an additional build step.

@ryangclark
Copy link
Contributor Author

Types generated.

Thanks for your review, and for all your previous work.

@dominikg dominikg merged commit 8ae3dc8 into sveltejs:main Apr 8, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants