Fixed language detection for no regional variant #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refines the approach to extracting language codes from the `Accept-Language` header. By employing a unified regex pattern, the code now efficiently captures both simple language codes and those with regional variants. The language code extraction logic now also splits on both hyphens and underscores, defaulting to the primary language code in cases of regional variants, and always converts the result to lowercase for consistent processing.
✅ Deploy Preview for locale-router-advanced canceled.
|
✅ Deploy Preview for component-scoped-ssr canceled.
|
✅ Deploy Preview for multi-page-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for component-scoped-csr canceled.
|
✅ Deploy Preview for locale-router-static canceled.
|
✅ Deploy Preview for preprocess-example canceled.
|
✅ Deploy Preview for single-load canceled.
|
✅ Deploy Preview for loaders-example canceled.
|
✅ Deploy Preview for locale-param canceled.
|
✅ Deploy Preview for fallback-locale canceled.
|
✅ Deploy Preview for parser-icu canceled.
|
✅ Deploy Preview for one-page-example canceled.
|
✅ Deploy Preview for parser-default canceled.
|
alcibiadesc
added a commit
to alcibiadesc/lib
that referenced
this pull request
Mar 21, 2024
This commit refines the approach to extracting language codes from the `Accept-Language` header. By employing a unified regex pattern, the code now efficiently captures both simple language codes and those with regional variants. The language code extraction logic now also splits on both hyphens and underscores, defaulting to the primary language code in cases of regional variants, and always converts the result to lowercase for consistent processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refines the approach to extracting language codes from the
Accept-Languageheader.By employing a unified regex pattern, the code now efficiently captures both simple language codes and those with regional variants.
The language code extraction logic now also splits on both hyphens and underscores, defaulting to the primary language code in cases of regional variants, and always converts the result to lowercase for consistent processing.