Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 fix(types): add missing HTML attributes to InputProps #38

Merged
merged 1 commit into from
Dec 28, 2023
Merged

馃悰 fix(types): add missing HTML attributes to InputProps #38

merged 1 commit into from
Dec 28, 2023

Conversation

vostrnad
Copy link
Contributor

Fixes #37

The HTML element of <Input> can be either <input>, <select> or <textarea>, but InputProps currently only extends HTMLInputAttributes. It should also extend HTMLSelectAttributes and HTMLTextareaAttributes.

dysfunc
dysfunc approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@dysfunc dysfunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤馃徎

@dysfunc dysfunc merged commit 83a67a0 into sveltestrap:main Dec 28, 2023
2 checks passed
@dysfunc dysfunc added Priority: Low Bug, issue, or pull request is a P3 Type: Bug Something isn't working labels Dec 28, 2023
@dysfunc dysfunc added this to the v6.1.1 milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dysfunc dysfunc dysfunc approved these changes

Assignees
No one assigned
Labels
Priority: Low Bug, issue, or pull request is a P3 Type: Bug Something isn't working
Projects
Development
Status: Done
Milestone
v6.1.1
Development

Successfully merging this pull request may close these issues.

馃悰 Input does not accept property "rows"
2 participants
@vostrnad @dysfunc