Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix Input value property type #58

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

valmarv
Copy link
Contributor

@valmarv valmarv commented Feb 8, 2024

The Input "value" property type ends up being narrower because of the intersection with HTMLTextareaAttributes, seems like the best way to fix this would be to explicitly any it.

The "value" property type ends up being narrower because of the type intersection with HTMLTextareaAttributes, seems like the best way to fix this would be to explicitly any it.
@valmarv valmarv requested a review from dysfunc as a code owner February 8, 2024 15:51
Copy link
Contributor

@dysfunc dysfunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@dysfunc dysfunc merged commit 6647388 into sveltestrap:main Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants