[fix](@svelteui/core): missing pointer events in NumberInput

ISSUES CLOSED: #449
svelteuidev · Aug 24, 2023 · 8380ac7 · 8380ac7
1 parent 35a847b
commit 8380ac7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/svelteui-core/src/components/Input/Input.d.ts b/packages/svelteui-core/src/components/Input/Input.d.ts
@@ -26,6 +26,7 @@ export interface InputBaseProps<T = string> extends DefaultProps<InputElementTyp
 	disabled?: boolean;
 	size?: SvelteUISize;
 	resize?: CSS['resize'];
+	noPointerEventsRightSection?: boolean;
 	root?: Component | keyof HTMLElementTagNameMap;
 	value?: T;
 }

diff --git a/packages/svelteui-core/src/components/Input/Input.svelte b/packages/svelteui-core/src/components/Input/Input.svelte
@@ -33,7 +33,8 @@
 		type: $$Props['type'] = 'text',
 		placeholder: $$Props['placeholder'] = undefined,
 		autofocus: $$Props['autofocus'] = undefined,
-		resize: $$Props['resize'] = 'none';
+		resize: $$Props['resize'] = 'none',
+		noPointerEventsRightSection: $$Props['noPointerEventsRightSection'] = false;
 	export { className as class };
 
 	/** An action that forwards inner dom node events from parent component */
@@ -47,9 +48,6 @@
 	function isInput(root: string): root is Input {
 		return ['input', 'select', 'textarea', 'datalist'].includes(root);
 	}
-	function isSelect(root: string): boolean {
-		return root === 'select';
-	}
 	let isHTMLElement = true;
 	let isComponent = false;
 
@@ -231,7 +229,7 @@ Base component to create custom inputs
 	{#if showRightSection}
 		<div
 			{...rightSectionProps}
-			class={cx(classes.rightSection, { [classes.noPointerEvents]: isSelect(root) })}
+			class={cx(classes.rightSection, { [classes.noPointerEvents]: noPointerEventsRightSection })}
 		>
 			<slot name="rightSection" />
 		</div>

diff --git a/packages/svelteui-core/src/components/NativeSelect/NativeSelect.svelte b/packages/svelteui-core/src/components/NativeSelect/NativeSelect.svelte
@@ -94,6 +94,7 @@ Capture user feedback limited to large set of options
 		autocomplete="off"
 		invalid={Boolean(error)}
 		override={{ ...base, ...inputStyle }}
+		noPointerEventsRightSection
 		{size}
 		{icon}
 		{radius}