Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Add transitions on expanding in Sidebar #388

Merged
merged 7 commits into from Jun 20, 2023
Merged

[docs]: Add transitions on expanding in Sidebar #388

merged 7 commits into from Jun 20, 2023

Conversation

Caladan08
Copy link
Contributor

Description

Title

Before submitting the PR, please make sure you do the following

  • Read the Contributing guide
  • Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
  • Include a description of the changes made in the PR description and in the commit messages.
  • Include screenshots/videos of the changes made.
  • Verify that the linter and tests are passing, with yarn lint and yarn test or just run yarn prepush.

@BeeMargarida
Copy link
Member

BeeMargarida commented May 31, 2023

I've been away from the computer this week, I will take a look at this tomorrow

@BeeMargarida BeeMargarida added documentation Improvements or additions to documentation enhancement New feature or request labels May 31, 2023
Copy link
Member

@BeeMargarida BeeMargarida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice one problem with this change: when navigating to another page, the sidebar animates when opened, which creates a weird effect:

transition_sidebar.mp4

Perhaps it's best to remove the transitions in the sidebar sections for now.

apps/docs/src/routes/+layout.svelte Show resolved Hide resolved
@Caladan08
Copy link
Contributor Author

I notice one problem with this change: when navigating to another page, the sidebar animates when opened, which creates a weird effect:

Perhaps it's best to remove the transitions in the sidebar sections for now.

Yeah, for some reason, even though there is no change to the sidebar value when we navigate through the pages, it will still rerun the transition every time. I tried using #key as well but didn't work. Guess I gotta drop that idea

@BeeMargarida
Copy link
Member

BeeMargarida commented Jun 5, 2023

Yeah, for some reason, even though there is no change to the sidebar value when we navigate through the pages, it will still rerun the transition every time. I tried using #key as well but didn't work. Guess I gotta drop that idea

Hum, did you try adding the |local modifier to the transitions? Perhaps it fixes in this case

@Caladan08
Copy link
Contributor Author

Hum, did you try adding the |local modifier to the transitions? Perhaps it fixes in this case

Yeah, that works!

@Caladan08
Copy link
Contributor Author

I've added the latest commit in my fork but there seems to be some issue with merging. Could you take a look at it?

@BeeMargarida
Copy link
Member

BeeMargarida commented Jun 7, 2023

I've added the latest commit in my fork but there seems to be some issue with merging. Could you take a look at it?

It seems like a Github issue. It happened to me in another repo as well. Don't have the solution for it yet. Hum, not sure if force pushing would fix it

Nvm, it's fixed. I'll take a look at the conflicts

@BeeMargarida
Copy link
Member

Sorry, been busy, I'll pick it up today or tomorrow

@BeeMargarida
Copy link
Member

BeeMargarida commented Jun 20, 2023

Sorry again, I'll pick it up tomorrow for sure!

@BeeMargarida BeeMargarida merged commit fd9a3bb into svelteuidev:main Jun 20, 2023
1 check passed
@BeeMargarida
Copy link
Member

Thank you for this contribution! 🙌 And so sorry for the delay, life got a bit hectic for a while, now back to normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants