Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]: add disabled option to NativeSelect sample #404

Merged
merged 1 commit into from
Jun 21, 2023
Merged

[docs]: add disabled option to NativeSelect sample #404

merged 1 commit into from
Jun 21, 2023

Conversation

khalibloo
Copy link
Contributor

Description

Added a disabled option to the NativeSelect example.
Closes #381

image
image

Before submitting the PR, please make sure you do the following

  • Read the Contributing guide
  • Prefix your PR title with [@svelteui/core], [@svelteui/actions], [@svelteui/motion], [@svelteui/core], [core], or [docs].
  • Include a description of the changes made in the PR description and in the commit messages.
  • Include screenshots/videos of the changes made.
  • Verify that the linter and tests are passing, with yarn lint and yarn test or just run yarn prepush.

BeeMargarida
BeeMargarida approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@BeeMargarida BeeMargarida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@BeeMargarida BeeMargarida merged commit e0ac920 into svelteuidev:main Jun 21, 2023
1 check passed
@BeeMargarida BeeMargarida added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 21, 2023
@khalibloo khalibloo deleted the docs/native-select-disabled-option branch June 21, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeeMargarida BeeMargarida BeeMargarida approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve documentation of NativeSelect
2 participants
@khalibloo @BeeMargarida