-
-
Notifications
You must be signed in to change notification settings - Fork 408
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix localization when the Proc gets the object and extra options.
Signed-off-by: José Valim <jose.valim@gmail.com>
- Loading branch information
1 parent
7f93f13
commit 4a8cd9f
Showing
5 changed files
with
30 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a8cd9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting 18 errors when running tests with this commit :(
4a8cd9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just to clone this project and run the tests and all are ok.
What are the tests that are breaking?
4a8cd9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can reproduce. I'm using ruby2ruby and active record (2.3.5).
4a8cd9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's related to crappy alias_method_chain on interpolate method in activerecord-2.3.5/lib/active_record/i18n_interpolation_deprecation.rb
4a8cd9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anyone have a fix? Otherwise I will need to revert it!
4a8cd9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well...I would throw those crappy i18n_interpolation_deprecation.rb out from AR and release AR 2.3.6 ;)
4a8cd9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
4a8cd9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, 2.3.6 should be released shortly.
4a8cd9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't serious;) But that's great! It will also simplify the interpolation fix discussed in http://github.com/svenfuchs/i18n/commit/9d12bfa71d06ffbd42d9bb76172e6f0ca1fb474e.
4a8cd9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you going to upgrade bundled i18n to 0.4.0 as well?
4a8cd9f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please provide a patch? Bundling the new version and replacing the deprecated syntax {{}} by %{}? In the meanwhile, I will get I18n 0.4.0 release!