Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle :default => false correctly #144

Closed
wants to merge 1 commit into from

Conversation

jfirebaugh
Copy link
Contributor

Fixes #143.

I mentioned :default => nil in the issue, but that's harder to support and not something I actually need, so this PR doesn't address it.

@bogdan
Copy link
Contributor

bogdan commented Nov 28, 2012

+1 for this

@ndbroadbent
Copy link
Contributor

+1, please consider merging this. Currently, I'm doing :default => 0, and then testing for 0.

@radar
Copy link
Collaborator

radar commented Nov 3, 2016

Thanks for the PR! It's great that it still applies. I was able to work out a solution that worked for nil too, and it's on the default-false-or-nil branch. Once that's green, I'll merge this to master.

@radar radar added this to the 0.8.0 milestone Nov 3, 2016
@radar radar self-assigned this Nov 3, 2016
@radar
Copy link
Collaborator

radar commented Nov 3, 2016

I've just merged this branch to master.

Thanks!

@radar radar closed this Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:default => false doesn't work
4 participants