Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

date :order for EN #317

Closed
kagemusha opened this issue Mar 22, 2013 · 2 comments · Fixed by #363
Closed

date :order for EN #317

kagemusha opened this issue Mar 22, 2013 · 2 comments · Fixed by #363

Comments

@kagemusha
Copy link

Why is the date order for EN year, month, day and not month, day, year?

en-CA probably same problem (or maybe should be day-month-year)

en-AU also should be day-month-year (i think)

en-GB seems correct

Not sure what en-IN but should probably check.
@kuroda
Copy link
Collaborator

kuroda commented Mar 23, 2013

The data for en locale are just taken from the rails repository. The en locale works as an reference for other locales.

I don't know why they chose this order.

If you don't think it is correct, you should open an issue on the rails repository itself, or send it a pull request.

@digitalfrost
Copy link
Collaborator

@kagemusha did open an issue on the rails repository itself. Here is the link: rails/rails#9884

@kennyj submitted a patch to rails to change the date order: rails/rails#10020 5 month ago

@carlosantoniodasilva (Rails Core Team) gave the following feed back on the pull request:

This might break a considerable number of apps I guess =/. I'm not against the change, but lets wait for more feedback on changing that before merging.

The rails pull request is currently still open.

digitalfrost added a commit to digitalfrost/rails-i18n that referenced this issue Aug 23, 2013
@digitalfrost
Reintroduce en-US.yml
2e111c7 
Fixes svenfuchs#317 and the following Rails' ticket and pull request:
* rails/rails#9884
* rails/rails#10020
@digitalfrost digitalfrost mentioned this issue Aug 23, 2013
Merged
kuroda pushed a commit that referenced this issue Oct 5, 2013
@digitalfrost @kuroda
Reintroduce en-US.yml
10056af 
Fixes #317 and the following Rails' ticket and pull request:
* rails/rails#9884
* rails/rails#10020

(cherry picked from commit 2e111c7)
Signed-off-by: Tsutomu Kuroda <t-kuroda@oiax.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reintroduce en-US.yml digitalfrost/rails-i18n
3 participants
@kuroda @kagemusha @digitalfrost