Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better capitalization of months and weekdays for Croatian #1081

Merged
merged 2 commits into from
May 12, 2023

Conversation

vipera
Copy link

@vipera vipera commented May 12, 2023

Days of week and month names are only capitalized in Croatian when they appear at the beginning of a sentence.

This PR changes the locale to reflect that. Lowercase localizations are in line with others such as Italian, Hungarian, French, Spanish, etc.

Copy link
Contributor

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you also include an entry to the CHANGELOG?

Days of week and month names are only capitalized in Croatian when
they appear at the beginning of a sentence.
@vipera
Copy link
Author

vipera commented May 12, 2023

Thanks for the look @sunny! Sure thing, updated it 👍

Copy link
Contributor

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pama pama merged commit 140a026 into svenfuchs:master May 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants