New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add en.yml locale #244
Add en.yml locale #244
Conversation
And why should it be en-US by default and not en-GB? |
I thought it made more sense, but I don't really care. The same could be said for fr.yml tho. Let me know how I should proceed and if I need to switch to en-GB. |
I think the first line should not be |
@kuroda: oops, of course. I'll correct it but should I use the en-GB file or the en-US file as default? |
@Silex Personally +1 for en-US. |
Well, if en-US then everything is ready in this pull request then (I changed to |
Have you checked your locale file with The following keys have missing pluralizations. activemodel.errors.template.header activerecord.errors.template.header errors.template.header Could you fix them and send us a pull request again? |
It confuses me... If I do the following:
It's the only difference! My wild guess is that the en locale is already partially loaded in the activerecord gem? Any idea? |
@Silex I see. The I have fixed the check script and merged your commit. Thanks. |
Thank you! |
I'm in an app where we're using the simplest locales like "en, pt, fr" and for english only the country-flavored locales exist.
This adds en.yml so it's consistent with fr.yml and pt.yml, etc.