Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add en.yml locale #244

Closed
wants to merge 1 commit into from
Closed

Add en.yml locale #244

wants to merge 1 commit into from

Conversation

Silex
Copy link
Contributor

@Silex Silex commented Jun 28, 2012

I'm in an app where we're using the simplest locales like "en, pt, fr" and for english only the country-flavored locales exist.

This adds en.yml so it's consistent with fr.yml and pt.yml, etc.

@ariejan
Copy link
Collaborator

ariejan commented Jun 28, 2012

And why should it be en-US by default and not en-GB?

@Silex
Copy link
Contributor Author

Silex commented Jun 28, 2012

I thought it made more sense, but I don't really care. The same could be said for fr.yml tho.

Let me know how I should proceed and if I need to switch to en-GB.

@kuroda
Copy link
Collaborator

kuroda commented Jun 28, 2012

@Silex

I think the first line should not be en-US: but en:.

@Silex
Copy link
Contributor Author

Silex commented Jun 28, 2012

@kuroda: oops, of course. I'll correct it but should I use the en-GB file or the en-US file as default?

@kuroda
Copy link
Collaborator

kuroda commented Jun 28, 2012

@Silex Personally +1 for en-US.

@Silex
Copy link
Contributor Author

Silex commented Jun 29, 2012

Well, if en-US then everything is ready in this pull request then (I changed to en:).

@kuroda
Copy link
Collaborator

kuroda commented Jun 29, 2012

@Silex

Have you checked your locale file with thor locales:test en command? It reports following problems:

The following keys have missing pluralizations.
  activemodel.errors.template.header
  activerecord.errors.template.header
  errors.template.header

Could you fix them and send us a pull request again?

@Silex
Copy link
Contributor Author

Silex commented Jun 29, 2012

It confuses me... If I do the following:

silex@silex:~/work/rails-i18n (master) $ diff rails/locale/en.yml rails/locale/en-US.yml
1c1
< en:
---
> en-US:

It's the only difference! My wild guess is that the en locale is already partially loaded in the activerecord gem? Any idea?

@kuroda
Copy link
Collaborator

kuroda commented Jul 2, 2012

@Silex I see. The en locale is special because we check the key structure against the en locale.

I have fixed the check script and merged your commit. Thanks.

@kuroda kuroda closed this Jul 2, 2012
@Silex
Copy link
Contributor Author

Silex commented Jul 2, 2012

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants