Change confirmation error message for es-* locales #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the changes introduced in rails/rails#5942, but does not include the attribute name in the message because it reads weird and it would require adding an article, which in turn would require knowing the grammatical gender of the attribute. E.g., "no coincide con *la* contraseña" or "no coincide con *el* número de cuenta".
kuroda
added a commit
that referenced
this pull request
Sep 20, 2014
Change confirmation error message for es-* locales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the changes introduced in rails/rails#5942, but does not include the attribute name in the message because it reads weird and it would require adding an article, which in turn would require knowing the grammatical gender of the attribute. E.g., "no coincide con la contraseña" or "no coincide con el número de cuenta". I think simply saying "no coincide" (lit. "does not match") in the context of a confirmation field is enough to figure out what is wrong.