-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing locale as param does not work with rails 3.2.3 #36
Comments
I also had issue with 3.2.3. |
Indeed I have the same issue when running rspec tests in Rails 3.2.3. Rails 3.2.2 works correctly. |
Could one of you provide a failing test case or a small rails app exhibiting this behaviour? |
I couldn't reproduce the problem by adding a test case to router-filter unit tests. It seem to appear only in combination of rails 3.2.3 and rspec. |
I've tracked the source of the problem down to this commit in rails/rails@275ee0d The merging of the additional controller parameters in the test environment has been removed there. Haven't found a way around that though. Any ideas are appreciated |
I'm running into this as well, any updates or workarounds? |
Use Rails 3.2.2 :) |
Changing line 64 of filters/locale.rb from locale = params.delete(:locale) to locale = params[:locale] seems to fix this issue for RSpec at least, but I can't tell if it's going to affect anything else (filtered routes are still working properly in my development app) and I can't get the routing-filter tests to run here. |
Ok, I just spent a couple of hours to this issue and my conclusion is that it was a lucky coincidence that these tests ever worked. What happend on Rails <= 3.2.2 is basically this:
Rails 3.2.3 removes step 1, so now some params get lost as they get encoded in the url but not decoded by the router. The quick and easy workaround is adding RoutingFilter.active = false to your test_helper.rb or spec_helper.rb. If you are running tests for the routing you can re-enable routingfilter there, the router and thus routing-filter gets called correctly in those tests. |
Cool. Thanks for the fix and all the effort! On 7 mei 2012, at 23:15, yabawockreply@reply.github.com wrote:
|
Closing since the cause is in upstream rails, it's not a real bug and a viable workaround is available and documented. |
👍 Thanks for figuring this out, yabawock! |
Looks like passing locale in params does not work with rails 3.2.3 anymore.
The text was updated successfully, but these errors were encountered: