Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fine-grained GitHub Action trigger configuration #35

Merged

Conversation

svengreb
Copy link
Owner

Resolves #34

The CI GitHub Action Workflow used the `push` setting for the `on` field
in order to trigger the workflow. That was superficial and the workflow
was running for every new commit and PR.

To improve this behavior and prevent unnecessary workflow runs the
`push` field [1] of the `on` field [2] has been configured to only run
for the `main` branch and `v*` tags while the `pull_request` field [3]
is set without any specific configuration so that it runs for all PRs
regardless of the target branch.

[1]: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestbranchestags
[2]: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#on
[3]: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestpaths

GH-34
@svengreb svengreb added this to the Next milestone Aug 29, 2020
@svengreb svengreb self-assigned this Aug 29, 2020
@svengreb svengreb merged commit c184ae8 into main Aug 29, 2020
@svengreb svengreb deleted the improvement/gh-34-more-fine-grained-action-trigger-config branch August 29, 2020 08:51
@svengreb svengreb removed their assignment Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More fine-grained GitHub Action trigger configuration
1 participant