Optimize GitHub action workflow scope #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svengreb
force-pushed
the
improvement/gh-84-optimize-gh-action-workflow-scope
branch
from
16267da
to
a5fd04b
Compare
Before all jobs were summarized in the `ci` workflow [1] but not separated by their scope, e.g. only Node specific tasks. The workflow was also not optimized to only run when specific files have been changed which results in false-positive executions and wastes limited free tier and developer time. Therefore the `ci` workflow has been optimized. >> CI Node The new `ci-node` workflow… - only runs when any `*.js`, `*.json`, `*.md`, `*.yaml` and `*.yml` file has been modified. This matches the lint-staged [2], Prettier and remark configurations. See the extensive GitHub action documentations about `on.<push|pull_request>.paths` [4] and the filter pattern cheat sheet [5] for more details. - only runs for `ubuntu-latest` instead of a matrix with `macos-latest` and `windows-latest` since there is no platform specific code yet. - use cache `npm` dependencies which is possible as of `actions/setup-node@v2.2.0` [3]. [1]: https://github.com/svengreb/tmpl/blob/0bb40e35/.github/workflows/ci.yml [2]: https://github.com/svengreb/tmpl/blob/0bb40e35/lint-staged.config.js#L12-L13 [3]: https://github.com/actions/setup-node/releases/tag/v2.2.0 [4]: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestpaths [5]: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet GH-84
svengreb
force-pushed
the
improvement/gh-84-optimize-gh-action-workflow-scope
branch
from
a5fd04b
to
ed441c2
Compare
svengreb
deleted the
improvement/gh-84-optimize-gh-action-workflow-scope
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #84