Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoRiot tracking #82

Closed
TPS opened this issue Oct 16, 2022 · 2 comments · Fixed by #126
Closed

GeoRiot tracking #82

TPS opened this issue Oct 16, 2022 · 2 comments · Fixed by #126
Labels
help wanted Extra attention is needed

Comments

@TPS
Copy link

TPS commented Oct 16, 2022

@svenjacobs GeoRiot uses a similar, but not identical scheme, to #42. So 1 might run into

  • https://target.georiot.com/Proxy.ashx?tsid=8429&GR_URL=https%3A%2F%2Fwww.amazon.com%2Fdp%2FB0B3Q23BT4%3Ftag%3Dhawk-future-20%26linkCode%3Dogi%26th%3D1%26psc%3D1%26ascsubtag%3Dcbq-us-custom-tracking-20

which, of course, should just be

  • https://smile.amazon.com/dp/B0B3Q23BT4 (when the smile option is on)

So just the url-decoded value of parameter GR_URL is required. Then the 2nd pass from #79 would clean/fix the Amazon URL properly.

@svenjacobs
Copy link
Owner

I recently simplified the project architecture. Adding new sanitizers should be simple, especially when they are similar to existing ones. A pull request would be very welcomed. Same goes for your others issues #83 and #84. Thank you :)

@svenjacobs svenjacobs added the help wanted Extra attention is needed label Oct 16, 2022
@TPS
Copy link
Author

TPS commented Oct 16, 2022

Sadly, I'm no Android dev, just a heavy user, so I don't know how I could help this way. 🙇🏾‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants