Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkSynergy tracking #84

Closed
TPS opened this issue Oct 16, 2022 · 0 comments · Fixed by #124
Closed

LinkSynergy tracking #84

TPS opened this issue Oct 16, 2022 · 0 comments · Fixed by #124
Labels
help wanted Extra attention is needed

Comments

@TPS
Copy link

TPS commented Oct 16, 2022 •
edited

@svenjacobs LinkSynergy uses a similar, but not identical scheme, to #42. So 1 might run into

  • https://click.linksynergy.com/link?id=kXQk6%2AivFEQ&offerid=1123623.20516002704&type=15&murl=https%3A%2F%2Fwww.newegg.com%2Fp%2F23B-001E-003S3%3Fitem%3D9SIAGREJ3S5851&u1=cbq-us-custom-tracking

which, of course, should just be

  • https://www.newegg.com/p/23B-001E-003S3 (whenever NewEgg #83 gets implemented)

So just the url-decoded value of parameter murl is required. Then the 2nd pass from #79 would clean the NewEgg URL properly.
@svenjacobs svenjacobs mentioned this issue Oct 16, 2022
Closed
@svenjacobs svenjacobs added the help wanted Extra attention is needed label Oct 16, 2022
@aricooperdavis aricooperdavis mentioned this issue Nov 8, 2022
Merged
svenjacobs pushed a commit that referenced this issue Nov 8, 2022
@aricooperdavis
Support LinkSynergy links, fix #84 (#124)
ff120c9 
* Support LinkSynergy links, fix #84

* Fix linting error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support LinkSynergy links, fix #84
2 participants
@TPS @svenjacobs