feat: Add RevealOverlayInserter as an intermediate steps towards Multiplatform support #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenjacobs
force-pushed
the
feature/android-compat
branch
2 times, most recently
from
ae61a86
to
ecb6365
Compare
…iplatform support
svenjacobs
force-pushed
the
feature/android-compat
branch
from
ecb6365
to
4033c3a
Compare
svenjacobs
force-pushed
the
feature/android-compat
branch
from
3f82a71
to
f1263a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get rid of Android's
Contextdependency in the core artifact of Reveal, this pull requests introduces theRevealOverlayInserterwhich declares a strategy of how to insert the overlay composable into the composition.The
FullscreenRevealOverlayInserter, which is now part of the new artifactreveal-compat-android, represents the current behaviour and is currently the default for backwards compatibility. However it is recommended to useInPlaceRevealOverlayInserterfor apps written fully in Compose to ensure a future compatibility with Compose Multiplatform.