Skip to content

Commit

Permalink
Fix codacy code style issues
Browse files Browse the repository at this point in the history
  • Loading branch information
@svenschoenung
svenschoenung committed Mar 29, 2016
1 parent 11b46ae commit 98faff8
Show file tree
Hide file tree
Showing 2 changed files with 68 additions and 68 deletions.
30 changes: 15 additions & 15 deletions index.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function log(output, opts) {

if (stats.files[opts.type] > 0) {
output.push([
f(patternFiles, symbol, files, plur('file', files), opts.desc),
f(patternFiles, symbol, files, plur('file', files), opts.desc),
(!opts.showFilePct) ? '' :
f(patternFilePct, filePct),
(!opts.showProblems) ? '' :
Expand All @@ -41,15 +41,15 @@ function pct(i, n) {

function statistics(results, config) {
var problemCounts = { 'I': 0, 'W': 0, 'E': 0 };
var problemFiles = { 'I': new Set(), 'W': new Set(), 'E': new Set() };
var problemFiles = { 'I': new Set(), 'W': new Set(), 'E': new Set() };
var successFiles = new Set();

config.map(function(conf) {
successFiles.add(conf.file);
});

results.map(function(result) {
problemCounts[result.error.code[0]]++;
problemCounts[result.error.code[0]]++;
problemFiles[result.error.code[0]].add(result.file);
successFiles.delete(result.file);
});
Expand All @@ -71,7 +71,7 @@ function statistics(results, config) {
return stats;
}

function reporter(results, config, options) {
function reporter(results, config, options) {
options = extend({}, {
showSummaryOnSuccess: false,
showSummaryHeader: false,
Expand Down Expand Up @@ -184,20 +184,20 @@ function JSHintStylishSummary() {
}, opts)
);
};
};
};

this.stats = function() {
var opts = parseArguments(arguments);
return statistics(stats[opts.stat].results, stats[opts.stat].config);
};
this.stats = function() {
var opts = parseArguments(arguments);
return statistics(stats[opts.stat].results, stats[opts.stat].config);
};

this.create = function() {
return new JSHintStylishSummary();
};
this.create = function() {
return new JSHintStylishSummary();
};

this.toString = function() {
return __filename;
};
this.toString = function() {
return __filename;
};
}

module.exports = new JSHintStylishSummary();
106 changes: 53 additions & 53 deletions test.js
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

/*global describe:false, it:false*/
/* global describe:false, it:false */

var chai = require('chai');
chai.use(require('chai-spies'));
Expand Down Expand Up @@ -42,63 +42,63 @@ describe('summary.create', function() {

describe('summary.collect', function() {
it('it should populate default statistics object', function(done) {
testCollect('test/test1/*.js',summary.collect(), function() {
var stats = summary.stats();
expect(stats.files.total).to.equal(3);
expect(stats.files.success).to.equal(1);
expect(stats.files.warning).to.equal(2);
expect(stats.files.error).to.equal(1);
expect(stats.files.problem).to.equal(2);
expect(stats.files.successPct).to.be.within(33.33, 33.34);
expect(stats.files.warningPct).to.be.within(66.66, 66.67);
expect(stats.files.errorPct).to.be.within(33.33, 33.34);
expect(stats.problems.warning).to.equal(3);
expect(stats.problems.error).to.equal(2);
expect(stats.problems.total).to.equal(5);
testCollect('test/test1/*.js', summary.collect(), function() {
var stats1 = summary.stats();
expect(stats1.files.total).to.equal(3);
expect(stats1.files.success).to.equal(1);
expect(stats1.files.warning).to.equal(2);
expect(stats1.files.error).to.equal(1);
expect(stats1.files.problem).to.equal(2);
expect(stats1.files.successPct).to.be.within(33.33, 33.34);
expect(stats1.files.warningPct).to.be.within(66.66, 66.67);
expect(stats1.files.errorPct).to.be.within(33.33, 33.34);
expect(stats1.problems.warning).to.equal(3);
expect(stats1.problems.error).to.equal(2);
expect(stats1.problems.total).to.equal(5);
testCollect('test/test2/*.js', summary.collect(), function() {
var stats = summary.stats();
expect(stats.files.total).to.equal(6);
expect(stats.files.success).to.equal(2);
expect(stats.files.warning).to.equal(4);
expect(stats.files.error).to.equal(2);
expect(stats.files.problem).to.equal(4);
expect(stats.files.successPct).to.be.within(33.33, 33.34);
expect(stats.files.warningPct).to.be.within(66.66, 66.67);
expect(stats.files.errorPct).to.be.within(33.33, 33.34);
expect(stats.problems.warning).to.equal(6);
expect(stats.problems.error).to.equal(4);
expect(stats.problems.total).to.equal(10);
var stats2 = summary.stats();
expect(stats2.files.total).to.equal(6);
expect(stats2.files.success).to.equal(2);
expect(stats2.files.warning).to.equal(4);
expect(stats2.files.error).to.equal(2);
expect(stats2.files.problem).to.equal(4);
expect(stats2.files.successPct).to.be.within(33.33, 33.34);
expect(stats2.files.warningPct).to.be.within(66.66, 66.67);
expect(stats2.files.errorPct).to.be.within(33.33, 33.34);
expect(stats2.problems.warning).to.equal(6);
expect(stats2.problems.error).to.equal(4);
expect(stats2.problems.total).to.equal(10);
done();
});
});
});
it('it should populate named statistics object', function(done) {
testCollect('test/test1/*.js',summary.collect('stats1'), function() {
var stats = summary.stats('stats1');
expect(stats.files.total).to.equal(3);
expect(stats.files.success).to.equal(1);
expect(stats.files.warning).to.equal(2);
expect(stats.files.error).to.equal(1);
expect(stats.files.problem).to.equal(2);
expect(stats.files.successPct).to.be.within(33.33, 33.34);
expect(stats.files.warningPct).to.be.within(66.66, 66.67);
expect(stats.files.errorPct).to.be.within(33.33, 33.34);
expect(stats.problems.warning).to.equal(3);
expect(stats.problems.error).to.equal(2);
expect(stats.problems.total).to.equal(5);
testCollect('test/test1/*.js', summary.collect('stats1'), function() {
var stats1 = summary.stats('stats1');
expect(stats1.files.total).to.equal(3);
expect(stats1.files.success).to.equal(1);
expect(stats1.files.warning).to.equal(2);
expect(stats1.files.error).to.equal(1);
expect(stats1.files.problem).to.equal(2);
expect(stats1.files.successPct).to.be.within(33.33, 33.34);
expect(stats1.files.warningPct).to.be.within(66.66, 66.67);
expect(stats1.files.errorPct).to.be.within(33.33, 33.34);
expect(stats1.problems.warning).to.equal(3);
expect(stats1.problems.error).to.equal(2);
expect(stats1.problems.total).to.equal(5);
testCollect('test/test1/*.js', summary.collect('stats2'), function() {
var stats = summary.stats('stats2');
expect(stats.files.total).to.equal(3);
expect(stats.files.success).to.equal(1);
expect(stats.files.warning).to.equal(2);
expect(stats.files.error).to.equal(1);
expect(stats.files.problem).to.equal(2);
expect(stats.files.successPct).to.be.within(33.33, 33.34);
expect(stats.files.warningPct).to.be.within(66.66, 66.67);
expect(stats.files.errorPct).to.be.within(33.33, 33.34);
expect(stats.problems.warning).to.equal(3);
expect(stats.problems.error).to.equal(2);
expect(stats.problems.total).to.equal(5);
var stats2 = summary.stats('stats2');
expect(stats2.files.total).to.equal(3);
expect(stats2.files.success).to.equal(1);
expect(stats2.files.warning).to.equal(2);
expect(stats2.files.error).to.equal(1);
expect(stats2.files.problem).to.equal(2);
expect(stats2.files.successPct).to.be.within(33.33, 33.34);
expect(stats2.files.warningPct).to.be.within(66.66, 66.67);
expect(stats2.files.errorPct).to.be.within(33.33, 33.34);
expect(stats2.problems.warning).to.equal(3);
expect(stats2.problems.error).to.equal(2);
expect(stats2.problems.total).to.equal(5);
done();
});
});
Expand All @@ -111,7 +111,7 @@ describe('summary.summarize', function() {
print: function(output) {
expect(output).to.be.a('string');
expect(output).to.match(/files? checked/);
done();
done();
}
}]);
});
Expand Down Expand Up @@ -147,7 +147,7 @@ describe('summary.summarize', function() {
}]);
});
it('it should honor showSummaryOnSuccess:false option', function(done) {
var spy = chai.spy();
var spy = chai.spy();
testSummarize('test/test1/good.js', [{
showSummaryOnSuccess: false,
print: spy
Expand Down

0 comments on commit 98faff8

Please sign in to comment.