Ignore readonly metadata and handle errors instead #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svenstaro Sorry I'll be away from my PC for a while, can you please fix the formatting so this PR doesn't stay hanging? Thanks |
|
Thanks! We don't have a test for it but I trust your fix. :) |
svenstaro
added a commit
that referenced
this pull request
Jan 13, 2024
|
I just tested... and I confirm it works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #994, check the issue for more information. Tested on Windows, and also confirmed that real permission error throws 401 as requested. Logs show like this: