Split project into multiple files #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenstaro
reviewed
Feb 13, 2019
svenstaro
reviewed
Feb 13, 2019
|
Overall this looks pretty good with some minor changes! Since we're already at this, would you mind adding proper docstrings to everything? :P |
This was referenced Feb 13, 2019
Closed
vojta7
pushed a commit
to vojta7/miniserve
that referenced
this pull request
Apr 3, 2019
Split project into multiple files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my attempt to split the project into multiple files. If you're not OK with the file hierarchy, please tell me, I can adapt it to your needs :)