Add generate QR code

[wyhaya]

#45

[svenstaro]

Great stuff! A few things:

• I think there should be a CLI switch to disable this function (to keep the UI tidy for people who don't like the visual bloat).
• Could you add a parametrized test for this that checks multiple values for the qrcode param and see whether you can trigger the error, too?

[svenstaro]

Also this needs a rebase.

[svenstaro]

Do you also want to tackle the task of printing a QR code in the terminal if requested via option flag? That was part of issue #45 but it should likely be done in a separate PR if you want to do it.

[wyhaya]

I think there should be a CLI switch to disable this function (to keep the UI tidy for people who don't like the visual bloat).

It may be considered to add a CLI switch, but is there too many switches at present, it is difficult for users to understand each function, maybe we can make the style smaller?

Could you add a parametrized test for this that checks multiple values for the qrcode param and see whether you can trigger the error, too?

Ok i will add as soon as possible.

Do you also want to tackle the task of printing a QR code in the terminal if requested via option flag? That was part of issue #45 but it should likely be done in a separate PR if you want to do it.

Yes, but what characters should we use? The terminal cannot be completely set to a square, because it is impossible to control the user’s line-height, it is usually difficult to scan successfully

Reference: qrcode-rust

---

Using " " and "██" may be closer, but it will take up more space, users need to change the size of the terminal before they can scan.

[svenstaro]

I think there should be a CLI switch to disable this function (to keep the UI tidy for people who don't like the visual bloat).

It may be considered to add a CLI switch, but is there too many switches at present, it is difficult for users to understand each function, maybe we can make the style smaller?

I definitely am worried about making the tool too complex as it touts itself as being simple. However, I think at current we can handle a --no-qr (or similar) flag just fine.

Do you also want to tackle the task of printing a QR code in the terminal if requested via option flag? That was part of issue #45 but it should likely be done in a separate PR if you want to do it.

Yes, but what characters should we use? The terminal cannot be completely set to a square, because it is impossible to control the user’s line-height, it is usually difficult to scan successfully

Reference: qrcode-rust

True, though its unicode mode works well enough for me so let's just roll with that for the time being.

[svenstaro]

FWIW the unicode string mode is gapless for me.

[wyhaya]

I added the --qrcode option, which is false by default. Do you think it is appropriate?

[svenstaro]

Looking pretty good now, I like the flag.

Can you add this feature to the list of features in the README? I think it's worth mentioning. :)

Any chance you can get rid of your merge commit and make it a rebase instead? Two actual commits are fine of course but the merge commit itself is not useful.

[svenstaro]

Looking good! Great work, thanks.