Removed sorting from CLI + added sorting from HTML #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
It would be optimal if you could try using unicode chars first. Then it will also look fine in lynx. :) |
|
Once you're happy with your code, remove WIP and I'll do a review. |
|
The default order should be to implicitly sort by name, right? It doesn't seem to be the case for me. I honestly can't tell which order the default is. It seems random. |
|
Apart from that, this actually seems really good and it's super fast. Great job! BTW what do you think about highlighting the currently hovered line? Should be a breeze in CSS. |
|
Also I just took a look and turns out actix-web now has typed URL params: https://docs.rs/actix-web/0.7.18/actix_web/struct.Query.html So we should probably use those. |
ghost
changed the title
ghost
mentioned this pull request
svenstaro
reviewed
Mar 5, 2019
svenstaro
requested changes
Mar 5, 2019
|
Merging as is. Great work! |
vojta7
pushed a commit
to vojta7/miniserve
that referenced
this pull request
Apr 3, 2019
Removed sorting from CLI + added sorting from HTML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is my WIP for solving #37
Right now, I can sort by name/size/date, in ascending and descending order by clicking the corresponding header. I'll clean up some parts of the code which, I think, could be simplified. Sorting by name is done using natural sort, does that seem fine to you ?