Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-24: Support for creating a new GH release in a foreign repository. #25

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

kittaakos
Copy link
Contributor

What is does:

This PR allows creating a GitHub release in a foreign repository. Inspired by GitHub Release task Azure task.

As PoC, I set up two repositories and crafted a release from one into the other:

Here is an overview of the required, additional secrets:

Screen Shot 2020-08-27 at 14 37 11

Here is the workflow that has created the new GH release:

Here is the GH release:

Please review. Thank you!


To be able to manage foreign repositories.
The owner and repo is extracted from the repo_name.
Otherwise, it uses the current repository.

Closes #24

Signed-off-by: Akos Kitta kittaakos@typefox.io

@kittaakos
Copy link
Contributor Author

@svenstaro, may I ask whether you're interested in this new feature? Thank you!

@svenstaro
Copy link
Owner

Well, I am and it sounds like a really cool feature but I'll have to take the time to really test this properly as I depend on this action and I know that many others do to so I want to make rather sure that I can support this properly. I'll likely need to set up one or two separate repos just for properly testing this.

@kittaakos
Copy link
Contributor Author

Thank you for the heads-up!

I'll have to take the time to really test this properly as I depend on this action

Sure, no hurry. I can keep using my fork and switch back to your action once this is merged. If there is anything I can assist you with, please let me know.

@svenstaro
Copy link
Owner

svenstaro commented Sep 25, 2020

Please also add repo_name to action.yml.

Sorry, turns out I'm blind and you did this.

README.md Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
@svenstaro
Copy link
Owner

Ok, finally reviewed this. Should be fine after a few minor fixes. :)

@OndrejSpanel
Copy link

I would be really interested in this functionality. Do you have any plans for it?

@svenstaro
Copy link
Owner

I would be really interested in this functionality. Do you have any plans for it?

Yes, I'll add it once the original author fixes their PR as reviewed.

@kittaakos
Copy link
Contributor Author

Ok, finally reviewed this. Should be fine after a few minor fixes. :)

Thank you for the review, @svenstaro 👍 I will try to address the remarks today and update the PR.

To be able to manage foreign repositories.
The `owner` and `repo` is extracted from the `repo_name`.
Otherwise, it uses the current repository.

Closes svenstaro#24

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@svenstaro svenstaro merged commit 697a9f1 into svenstaro:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature-request] Create a GH release in a foreign repository
3 participants