Do not prevent restart of authentication flow when showing IdP selection dialog #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…election dialog The first login attempt had set the login_hint parameter in the session. When restarting the flow the login_hint is still present in the session. If bypassing of the login page is enabeld, no option was given to change the username, but the login_hint from the previous attempt was reused. Solution is to no longer store the username as a login_hint. Need to check if this breaks something else, but automated tests look good so far. Closes #292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first login attempt had set the login_hint parameter in the session. When restarting the flow the login_hint is still present in the session. If bypassing of the login page is enabeld, no option was given to change the username, but the login_hint from the previous attempt was reused.
Solution is to no longer store the username as a login_hint. Need to check if this breaks something else, but automated tests look good so far.
Closes #292