Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset in P3Client>>connect drop password #3

Closed
bencoman opened this issue Jan 28, 2018 · 2 comments
Closed

Reset in P3Client>>connect drop password #3

bencoman opened this issue Jan 28, 2018 · 2 comments

Comments

@bencoman
Copy link

Just a few minutes in to trying P3. After doing...
Metacello new
baseline: 'P3';
repository: 'github://svenvc/P3';
load.

Doing...
(P3Client new url: 'psql://postgres:xxxxx@localhost:5432/nyc_data') in: [ :client |
[ client isWorking ] ensure: [ client close ] ].
produces... "P3Error PostgreSQL Password required"

Tracing through, in P3CLient>>connect I find...
self ==> a P3Client(psql://postgres:xxxxxx@localhost:5432/nyc_data)
before sending #reset, and after...
self ==> a P3Client(psql://localhost:5432/)

Now it works if I comment out "self reset".

@svenvc
Copy link
Owner

svenvc commented Jan 29, 2018

This was already noted and fixed in #2 which I just integrated and tested OK for me. Can you confirm ?

Thanks for the report.

@bencoman
Copy link
Author

I confirm that fixes the problem and close this issue. btw, the changes look low risk and probably worth rolling out to Baseline. I added a side-thought to #2.

svenvc added a commit that referenced this issue Dec 17, 2023
Use symbol as category in BaselineOfP3 definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants