New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Amidar #1
Added Amidar #1
Conversation
bezel-cfgs/amidar.cfg
Outdated
@@ -0,0 +1,12 @@ | |||
# 1941 Counter Attack Overlay for Retroarch with 4:3 Display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update the comment with the actual game name and you user name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, could you please tell me how I can change the comment? I have next to no experience with Github. Besides, Amidar is the actual game name. Or do you mean the romname? That would bei amidar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just got it that you meant my PR comment rather than the commit message from my repo. 🥴
I added the game name now. Which user name do you mean? Github or Retropie forum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Taranchul no, I meant in both bezel-cfgs/amidar.cfg
and bezel-cfgs/apb.cfg
files. The first line in those files is a comment with the name of the game, you copy-pasted the one from 1941 but forgot to change the comment ;)
Regarding the user name, use whatever you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, the stumbling stones of communication. Done. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Taranchul! Just fix the small request I have and we're good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: Posted my reply as a new review. See above.
bezel-cfgs/amidar.cfg
Outdated
@@ -0,0 +1,12 @@ | |||
# 1941 Counter Attack Overlay for Retroarch with 4:3 Display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, could you please tell me how I can change the comment? I have next to no experience with Github. Besides, Amidar is the actual game name. Or do you mean the romname? That would bei amidar.
Merged, thank you for your contribution! |
Add Amidar
My first 4:3 RetroArch overlay, hopefully the first of many others. :)
Note: I scaled the 1024 version down from 1600 without any adjustments. I hope it is acceptable. My attempts of re-writing the instruction box were even harder to read.