Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming Conventions #7

Closed
qbedard opened this issue Sep 16, 2020 · 3 comments · Fixed by #8
Closed

Naming Conventions #7

qbedard opened this issue Sep 16, 2020 · 3 comments · Fixed by #8

Comments

@qbedard
Copy link

qbedard commented Sep 16, 2020

I don't enjoy being "that guy", but why deviate from the built-in lua API's conventions by using camelCase instead of snake_case?

I found it surprising, and using some of vimpeccable's functions alongside built-in API functions looks disjointed with the differing cases to me.

@svermeulen
Copy link
Owner

svermeulen commented Sep 16, 2020

Oh, yeah I didn't even realize I was diverging from the standard, but you're right. Neovim API uses snake case. In retrospect I should have used that as well.

Maybe what we should do is change to that, and then deprecate the existing methods with warnings

@svermeulen
Copy link
Owner

Ok done. Thank god for vim-abolish to make this easy to do :)

@qbedard
Copy link
Author

qbedard commented Sep 17, 2020

Thank god for vim-abolish to make this easy to do :)

Omg, amen.

And awesome! Thanks for the quick response and turnaround! Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants