Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce the verbosity of pagination logging [again] #180

Merged
merged 4 commits into from May 2, 2021

Conversation

mohkale
Copy link
Contributor

@mohkale mohkale commented Feb 8, 2020

Sorry for the re-submission. I was having trouble with github somehow merging all the commits I'm force pushing automatically, and thus I couldn't keep them separate. Ended up just deleting my fork, reforking and then pushing again. It's working now 馃槃.

This pull request continues from #179

if users don't want to autopage generate tags, then don't keep telling
them it hasn't been configured :P
@sverrirs
Copy link
Owner

sverrirs commented Feb 8, 2020

Sorry I might have closed the other one by accident as I was going through the backlog yesterday. Thank you for taking the time to rebase, I will take a look at this change first time I get :)

Copy link
Owner

@sverrirs sverrirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this introduces new public config elements could you please update the autopages.md document to reflect these new options and add a small section explaining its use and examples.

@mohkale
Copy link
Contributor Author

mohkale commented Feb 8, 2020

I've added a section to the default options for the new silent option and a small comment explaining what it does. I'm not really sure it warrants much more, it's pretty self explanatory. If you'd like I could add a small paragraph explaining the exact difference in output 馃槃.

@sverrirs sverrirs merged commit e4e1d01 into sverrirs:master May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants