Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extract): adds more granularity to dependency types #884

Merged
merged 6 commits into from Dec 12, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Dec 10, 2023

Description

  • adds detection of more fine grained dependency types. See the updated documentation in this PR for a complete list.

Motivation and Context

... so it's possible to distinguish whether imports were done with require, triple slash directive (and if yes: with which type of triple slash directive), import, type-import, import-equals, dynamic import, ...).

Some of these were already possible with dedicated attributes like dynamic or moduleSystems but some weren't yet. For either case it'll make writing rules simpler as there's one spot where you can check them against.

How Has This Been Tested?

  • green ci
  • updated automated non-regression tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Dec 12, 2023

Code Climate has analyzed commit f8ef625 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 11127b5 into main Dec 12, 2023
12 checks passed
@sverweij sverweij deleted the feature/adds-more-granularity-to-dependency-types branch December 12, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant