Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extract): prevents classifying core modules as aliased-tsconfig-base-url #886

Merged

Conversation

sverweij
Copy link
Owner

Description, Motivation and Context

  • fixes the bug described in the title

How Has This Been Tested?

  • green ci
  • additional automated non-regression tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

Copy link

codeclimate bot commented Dec 13, 2023

Code Climate has analyzed commit c3b26a2 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 6d4c72c into main Dec 13, 2023
9 checks passed
@sverweij sverweij deleted the bugfix/donot-classify-core-as-aliased-tsconfig-base-url branch December 13, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant