feat!: makes entries in 'cycle' contain more information (BREAKING for API users) #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es, even when they weren't available in the source material + expand tests to include output with attributes
…emit it and summarization thing to properly de-duplicate it (name only)
…neeverywhere else
sverweij
changed the title
sverweij
changed the title
so we can use this for reaches/ reachable chains as well might the need arise
|
Code Climate has analyzed commit 8dece3a and detected 0 issues on this pull request. View more on Code Climate. |
Merged
10 tasks
sverweij
added a commit
that referenced
this pull request
Dec 25, 2023
…BREAKING for API users) (#895) ## Description - Same as #888, but for the path detection algorithm underlying 'reaches' and 'reachable' rules The addition to the _rule_ will be in a separate PR ## Motivation and Context - fixing #763 - this PR is a prerequisite to implement the feature requested in there - feature parity with similar restrictions on cycles ## How Has This Been Tested? - [x] green ci - [x] updated automated regression tests - [x] dog-fooding on dependency-cruiser ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Documentation only change - [ ] Refactor (non-breaking change which fixes an issue without changing functionality) - [x] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change) => for API only ## Checklist - [x] 📖 - My change doesn't require a documentation update, or ... - it _does_ and I have updated it - [x] ⚖️ - The contribution will be subject to [The MIT license](https://github.com/sverweij/dependency-cruiser/blob/main/LICENSE), and I'm OK with that. - The contribution is my own original work. - I am ok with the stuff in [**CONTRIBUTING.md**](https://github.com/sverweij/dependency-cruiser/blob/main/.github/CONTRIBUTING.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a breaking change on the API only - rules keep the same interface and behavior.
Motivation and Context
So we can define rules on the additional attributes - prerequisite to fixing #695
How Has This Been Tested?
Types of changes
Checklist
📖
⚖️