Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extract): adds "pre-compilation-only" to the dependencyTypes as well, when detected #892

Merged
merged 2 commits into from Dec 18, 2023

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Dec 18, 2023

Description

  • when a dependency classifies as preCompilationOnly: true also add "pre-compilation-only" to the dependencyTypes array for that dependency
  • in the default theme of the dot reporter
    • use the dependencyTypes array instead of the loose boolean attributes
    • also use the 'thin line' representation for things we can with high likelihood
      classify as pre-compilation only (type-only, type-import, tsd type import)

Motivation and Context

Consistency with other similar (derived or not) dependency types

How Has This Been Tested?

  • green ci
  • updated automated non-regression tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

…me + expand the 'pre compilation only' display to tsd, type imports, & type only imports
Copy link

codeclimate bot commented Dec 18, 2023

Code Climate has analyzed commit aa86b7b and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 0278445 into main Dec 18, 2023
10 checks passed
@sverweij sverweij deleted the feature/adds-pre-compilation-only-to-dependencyTypes branch December 18, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant