Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(init-config): makes stderr, stdout configurable - so we can easier test their uses #897

Merged
merged 2 commits into from Dec 28, 2023
Merged

refactor(init-config): makes stderr, stdout configurable - so we can easier test their uses #897

merged 2 commits into from Dec 28, 2023

Conversation

sverweij
Copy link
Owner

Description

  • adds out & err stream parameters to the init config
  • updates tests so they test for what is written to them

Motivation and Context

  • More reliable tests
  • Less stdout/ stderr poluting the standard test report

How Has This Been Tested?

  • green ci
  • adapted automated non-regression tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it

  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 28, 2023

Code Climate has analyzed commit b42c989 and detected 0 issues on this pull request.

View more on Code Climate.

@sverweij sverweij merged commit 3d31cc3 into main Dec 28, 2023
9 checks passed
@sverweij sverweij deleted the refactor/snooze-stdout-stderr-in-tests branch December 28, 2023 11:25
@sverweij sverweij mentioned this pull request Dec 28, 2023
Merged
9 tasks
sverweij added a commit that referenced this pull request Dec 28, 2023
@sverweij
refactor(cli): makes stderr, stdout configurable - so we can test the…
b9d4d2b 
…ir uses more easily (#898)

## Description, Motivation and Context

- same as #897, but instead for the CLI
- removes now unnecessary intercept-stdout devDependency 

## How Has This Been Tested?

- [x] green ci
- [x] adapted automated non-regression tests

## Types of changes

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Documentation only change
- [x] Refactor (non-breaking change which fixes an issue without
changing functionality)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sverweij