Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manifest): on publish removes devDependencies & scripts #905

Merged
merged 1 commit into from Jan 27, 2024

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Jan 27, 2024

Description

  • on publish removes devDependencies, scripts and other stuff not necessary to have for runtime dependency-cruiser usage
  • also on publish: adds a dummy 'test' script with a message to run tests etcetera on the ci (and so socket.dev doesn't shows its bogus warning about missing tests, which shouldn't be on npmjs in the first place)

Motivation and Context

  • Makes the published package ~10kb smaller

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 馃摉

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • 鈿栵笍

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

and add a dummy 'test' script with a message to run tests etcetera on the ci (and so socket.dev doesn't shows its bogus warning about missing tests, which shouldn't be on npmjs in the first place)
Copy link

codeclimate bot commented Jan 27, 2024

Code Climate has analyzed commit 46cb50e and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

New dependencies detected. Learn more about Socket for GitHub 鈫楋笌

Package New capabilities Transitives Size Publisher
npm/clean-pkg-json@1.2.0 None 0 43.2 kB hirokiosame

View full report鈫楋笌

@sverweij sverweij changed the title ci: on publish removes devDependencies & scripts feat(manifest): on publish removes devDependencies & scripts Jan 27, 2024
@sverweij sverweij merged commit 24b3b2e into main Jan 27, 2024
12 checks passed
@sverweij sverweij deleted the feature/clean-manifest-before-publishing branch January 27, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant