Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: do not up peerDependencies #16

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Oct 17, 2020

Description, Motivation and Context

Makes sure peerDependencies don't get updated. See addition to the README for motivation & context.

Later on we might introduce a cli option for this, but this covers my current needs.

How Has This Been Tested?

  • additional automated tests
  • automated non-regression tests
  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the feature/donot-up-peer-dependencies branch from 15cd2fb to 01b9262 Compare October 17, 2020 10:31
- also kicks node 13 from the build matrix

later on we might introduce a cli option for this, but this covers my current needs
@sverweij sverweij force-pushed the feature/donot-up-peer-dependencies branch from 01b9262 to cf2a68c Compare October 17, 2020 10:33
@codeclimate
Copy link

codeclimate bot commented Oct 17, 2020

Code Climate has analyzed commit cf2a68c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit c9ccd48 into master Oct 17, 2020
@sverweij sverweij deleted the feature/donot-up-peer-dependencies branch October 17, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant