Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replaces get-stdin with process.stdin #25

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

sverweij
Copy link
Owner

Description

  • replaces get-stdin with process.stdin that ships with node by default

Motivation and Context

Working with process.stdin is arguably a tiny bit more complicated/ less elegant than with get-stdin, but does away with a 3rd party dependency that needs to be managed (& downloaded).

How Has This Been Tested?

  • green ci
  • additional manual testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij merged commit 9e2c370 into master Aug 14, 2022
@sverweij sverweij deleted the refactor/replace-get-stdin-with-process-stdin branch August 14, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant