Ad missing check for index outside arrary (#892)

* Fixes #888 'polyline draw error !Index was outside the bounds of the array' issue * Add test * Update ReleaseNotes.md
svg-net · Sep 4, 2021 · a7088cf · a7088cf
1 parent 68ade05
commit a7088cf
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 3 deletions.
diff --git a/Source/Basic Shapes/SvgMarkerElement.cs b/Source/Basic Shapes/SvgMarkerElement.cs
@@ -58,9 +58,12 @@ protected internal override bool RenderStroke(ISvgRenderer renderer)
                 {
                     ++index;
                 }
-                var refPoint2 = path.PathPoints[index];
-                var marker = OwnerDocument.GetElementById<SvgMarker>(markerStart.ToString());
-                marker.RenderMarker(renderer, this, refPoint1, refPoint1, refPoint2, true);
+                if (index < pathLength)
+                {
+                    var refPoint2 = path.PathPoints[index];
+                    var marker = OwnerDocument.GetElementById<SvgMarker>(markerStart.ToString());
+                    marker.RenderMarker(renderer, this, refPoint1, refPoint1, refPoint2, true);
+                }
             }
 
             var markerMid = MarkerMid.ReplaceWithNullIfNone();

diff --git a/Tests/Svg.UnitTests/PassingTests.csv b/Tests/Svg.UnitTests/PassingTests.csv
@@ -243,6 +243,7 @@ __issue-769-01
 __issue-785-01
 __issue-863-01
 __issue-886-01
+__issue-888-01
 __pull_request-373-01
 __pull_request-374-01
 __pull_request-414-01

diff --git a/Tests/W3CTestSuite/PassingTests.txt b/Tests/W3CTestSuite/PassingTests.txt
@@ -277,6 +277,7 @@ __issue-769-01.svg
 __issue-785-01.svg
 __issue-863-01.svg
 __issue-886-01.svg
+__issue-888-01.svg
 __pull_request-373-01.svg
 __pull_request-374-01.svg
 __pull_request-414-01.svg

diff --git a/Tests/W3CTestSuite/png/__issue-888-01.png b/Tests/W3CTestSuite/png/__issue-888-01.png
diff --git a/Tests/W3CTestSuite/svg/__issue-888-01.svg b/Tests/W3CTestSuite/svg/__issue-888-01.svg
diff --git a/doc/ReleaseNotes.md b/doc/ReleaseNotes.md
@@ -26,6 +26,7 @@ The release versions are NuGet releases.
 * prevent `ISvgRenderer.SmoothingMode` reset when `RequiresSmoothRendering` is `true`
   (see [#882](https://github.com/svg-net/SVG/issues/882))
 * ignore `x` and `y` attributes in outermost svg as per standard (see [#886](https://github.com/svg-net/SVG/issues/886))
+* fixed index is outside arrary boundary (see [#888](https://github.com/svg-net/SVG/issues/888))
 
 ## [Version 3.2.3](https://www.nuget.org/packages/Svg/3.2.3)